circuits: Remove ViewKey from TxOutputNote::new
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/191_circuit_output
branch
from
b9f03fc to
1e303b6
Compare
moCello
changed the title
TxOutputNote::newViewKey from TxOutputNote::new
HDauven
approved these changes
May 31, 2024
circuits/src/transaction.rs
Outdated
| let value_commitment = JubJubScalar::from(value); | ||
| let value_commitment = (GENERATOR_EXTENDED * value_commitment) | ||
| + (GENERATOR_NUMS_EXTENDED * blinding_factor); | ||
| let value_commitment = JubJubAffine::from(value_commitment); |
There was a problem hiding this comment.
Not sure if I'm a fan of all this variable shadowing here, but if we do this more often ignore this comment.
moCello
force-pushed
the
mocello/191_circuit_output
branch
from
1e303b6 to
63fba18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #191