Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add sender public key to note costructors #218

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Jun 18, 2024

Resolves #214

@moCello moCello force-pushed the mocello/214_sender_enc2 branch 3 times, most recently from d29df46 to 73991d9 Compare June 18, 2024 16:02
@moCello moCello marked this pull request as draft June 18, 2024 16:13
@moCello moCello force-pushed the mocello/214_sender_enc2 branch from 9ce352c to 4bfa482 Compare June 19, 2024 12:19
@moCello moCello marked this pull request as ready for review June 19, 2024 12:23
@moCello moCello requested review from xevisalle, ureeves and HDauven June 19, 2024 12:23
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add that change to the changelog, and double-check the "receiver" wording

core/src/encryption/elgamal.rs Show resolved Hide resolved
core/src/note.rs Show resolved Hide resolved
@moCello moCello merged commit 165d37c into master Jun 19, 2024
6 checks passed
@moCello moCello deleted the mocello/214_sender_enc2 branch June 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sender encryption to the Note
3 participants