core: Add Sender struct
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/222_sender
branch
2 times, most recently
from
dfe6847 to
9b9a70f
Compare
moCello
force-pushed
the
mocello/222_sender
branch
from
9b9a70f to
00a2c40
Compare
xevisalle
approved these changes
Jun 25, 2024
| /// Create a new [`Sender`] enum by encrypting the sender's [`PublicKey`] in | ||
| /// a way that only the receiver of the note can decrypt. | ||
| pub fn encrypt( | ||
| note_pk: &NotePublicKey, |
There was a problem hiding this comment.
I'd call this recipient_note_pk
There was a problem hiding this comment.
Do you insist? Because I think it adds more noise. In the end the npk of the stealth-address is used.
ureeves
requested changes
Jun 25, 2024
ureeves
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #222