circuit: Make TxInputNote fields public
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/circuit_inputs
branch
from
d631172 to
62769e6
Compare
xevisalle
reviewed
Jun 25, 2024
| self.max_fee, | ||
| self.deposit, | ||
| )?; | ||
| // Append the root as public input |
There was a problem hiding this comment.
which is the advantage of adding this here and changing the already peer-reviewed comments?
There was a problem hiding this comment.
Ease of work: the other file was a real pain to debug and I changed only the comments that directly refer to the steps 1 - 6 in the documentation of the function.
I also thought that it is good to have the circuit implementation be more close to the circuit outlined in the specs with clear markers where what things are checked (e.g. membership, ownership, etc)
moCello
force-pushed
the
mocello/circuit_inputs
branch
from
62769e6 to
9f0713d
Compare
moCello
force-pushed
the
mocello/circuit_inputs
branch
from
9f0713d to
89202bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the fields of
TxInputNoteso it can also be constructed from the internal fields, without the sender-sk.