Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Change owns to take a StealthAddress #225

Merged
merged 1 commit into from
Jun 27, 2024
Merged

core: Change owns to take a StealthAddress #225

merged 1 commit into from
Jun 27, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Jun 26, 2024

These changes are required after the deletion of the Ownable trait, in order for the functions to take both Notes and Licenses

@moCello moCello requested review from xevisalle, ureeves and HDauven June 26, 2024 16:33
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, but I have two questions:

  • since the code with note still works, why the change is needed?
  • if the change is needed, maybe sk.owns(sa) feels weird? sk.check_sa(sa) or similar is more appropiate?

@HDauven
Copy link
Member

HDauven commented Jun 26, 2024

  • if the change is needed, maybe sk.owns(sa) feels weird? sk.check_sa(sa) or similar is more appropiate?

I prefer sk.owns(sa) because it clearly conveys the relationship between the secret key and the ownership of the stealth address. It is much more declarative.

@moCello
Copy link
Member Author

moCello commented Jun 27, 2024

it looks good to me, but I have two questions:

* since the code with `note` still works, why the change is needed?

Because it doesn't work with Licenses.

* if the change is needed, maybe `sk.owns(sa)` feels weird? `sk.check_sa(sa)` or similar is more appropiate?

This would create more unneeded changes downstream that I like to avoid at this point.

@moCello moCello merged commit b462dd3 into master Jun 27, 2024
6 checks passed
@moCello moCello deleted the mocello/owns branch June 27, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants