Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circuits: Re-do TxCircuit construction #230

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Aug 6, 2024

Resolves #229

@moCello moCello force-pushed the mocello/229_circuit_api branch 2 times, most recently from 2d01728 to dd7ba18 Compare August 6, 2024 10:09
@moCello moCello marked this pull request as draft August 7, 2024 08:36
@moCello moCello force-pushed the mocello/229_circuit_api branch from dd7ba18 to a950805 Compare August 7, 2024 09:19
@moCello moCello force-pushed the mocello/229_circuit_api branch from a950805 to 0509fbd Compare August 7, 2024 09:25
@moCello moCello marked this pull request as ready for review August 7, 2024 14:14
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

circuits/src/lib.rs Show resolved Hide resolved
circuits/src/lib.rs Show resolved Hide resolved
@moCello moCello merged commit 419fceb into master Aug 8, 2024
6 checks passed
@moCello moCello deleted the mocello/229_circuit_api branch August 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circuits: Restructure API for circuit creation
2 participants