Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added serde support #257

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Added serde support #257

merged 1 commit into from
Dec 17, 2024
+816 −1

Conversation

d-sonuga
Copy link
Contributor

@d-sonuga d-sonuga commented Dec 9, 2024 •
edited by Neotamandua
Loading

@moCello moCello mentioned this pull request Dec 12, 2024
Open
@d-sonuga d-sonuga marked this pull request as ready for review December 13, 2024 13:50
Neotamandua
Neotamandua reviewed Dec 16, 2024
View reviewed changes
core/src/serde_support.rs

// To serialize and deserialize u64s as big ints:
// https://github.com/dusk-network/rusk/issues/2773#issuecomment-2519791322.
struct Bigint(u64);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also needed in other repositories?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other repos' structs didn't have any u64s to serialize.

core/src/serde_support.rs Outdated Show resolved Hide resolved
@Neotamandua Neotamandua requested a review from miloszm December 16, 2024 13:44
moCello
moCello reviewed Dec 16, 2024
View reviewed changes
core/src/serde_support.rs Outdated Show resolved Hide resolved
@d-sonuga d-sonuga requested a review from moCello December 16, 2024 17:51
Neotamandua
Neotamandua requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@Neotamandua Neotamandua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to run this again in the CI, so that the tests will be executed as well in the future.

@d-sonuga d-sonuga requested a review from Neotamandua December 16, 2024 18:40
moCello
moCello reviewed Dec 17, 2024
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
@d-sonuga d-sonuga requested a review from moCello December 17, 2024 11:48
moCello
moCello approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side but please make sure that @Neotamandua is also on board with all the changes

Neotamandua
Neotamandua approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Neotamandua Neotamandua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. The only thing I would have suggested is to add a similar test as in piecrust to catch the case where a struct field is changed, but I don't think that's really needed here, so let's leave it as is.

@d-sonuga d-sonuga merged commit 1c944f4 into master Dec 17, 2024
7 checks passed
@d-sonuga d-sonuga deleted the add-serde-support branch December 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neotamandua Neotamandua Neotamandua approved these changes

@moCello moCello moCello approved these changes

@miloszm miloszm Awaiting requested review from miloszm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-sonuga @moCello @Neotamandua