Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute the AES key using HKDF #260

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Compute the AES key using HKDF #260

merged 3 commits into from
Dec 18, 2024
+43 −10

Conversation

xevisalle
Copy link
Member

@xevisalle xevisalle commented Dec 17, 2024 •
edited
Loading

Resolves: #261

@xevisalle xevisalle force-pushed the hash_key branch 3 times, most recently from 35a41c7 to 3dbce97 Compare December 17, 2024 18:50
@xevisalle xevisalle changed the title Hash the shared key Compute the AES key using HKDF Dec 17, 2024
marta-belles
marta-belles reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@marta-belles marta-belles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but I think it's best if a dev also takes a look at it.

Neotamandua
Neotamandua reviewed Dec 17, 2024
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
@xevisalle xevisalle linked an issue Dec 18, 2024 that may be closed by this pull request
core: Improve key derivation for AES #261
Closed
moCello
moCello approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/CHANGELOG.md Outdated Show resolved Hide resolved
Neotamandua
Neotamandua approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Neotamandua Neotamandua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/CHANGELOG.md Outdated Show resolved Hide resolved
herr-seppia
herr-seppia reviewed Dec 18, 2024
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
@xevisalle xevisalle merged commit 434ded6 into master Dec 18, 2024
7 checks passed
@xevisalle xevisalle deleted the hash_key branch December 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neotamandua Neotamandua Neotamandua approved these changes

@moCello moCello moCello approved these changes

@ZER0 ZER0 Awaiting requested review from ZER0

@HDauven HDauven Awaiting requested review from HDauven

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

@marta-belles marta-belles Awaiting requested review from marta-belles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: Improve key derivation for AES
5 participants
@xevisalle @moCello @marta-belles @herr-seppia @Neotamandua