Switch from wasmer to wasmtime
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
force-pushed
the
wasmtime
branch
3 times, most recently
from
919f14b to
f0817ae
Compare
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
moCello,
herr-seppia and
Neotamandua
HDauven
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Not much to add from my side, just a couple of questions. Overall it's a very nice change.
Given that a whole runtime swap-out only touched <1k LOC is an achievement in itself.
Also nice to see the minimum memory page requirement is gone. Looking forward to the 64-bit port!
We switch WebAssembly runtime - from `wasmer` to `wasmtime` - to make use of the features it has available, notably `memory64` support. In the process we are one step further to having 64-bit contracts, and have gotten rid of the 4 page minimum memory requirement. See-also: #281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switch WebAssembly runtime - from
wasmertowasmtime- to makeuse of the features it has available, notably
memory64support.In the process we are one step further to having 64-bit contracts, and
have gotten rid of the 4 page minimum memory requirement.
See-also: #281