Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post-error root calculation #293

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Fix post-error root calculation #293

merged 4 commits into from
Nov 26, 2023

Conversation

ureeves
Copy link
Member

@ureeves ureeves commented Nov 21, 2023 •
edited
Loading

Resolves #296

@ureeves ureeves force-pushed the after_error_root branch 2 times, most recently from 2f37155 to a8a583e Compare November 21, 2023 13:45
@ureeves ureeves mentioned this pull request Nov 22, 2023
Closed
Eduardo Leegwater Simões added 4 commits November 22, 2023 14:57
contracts: add panik call to callcenter
eea12dc
piecrust: add root_equal_on_err test
29a05e1
crumbles: add apply_revert_apply test
fd273d1
piecrust: re-instantiate contracts after a call
0159afa 
Keeping instances in the session after a call has returned poses a
problem, since the stack is left *even when the call returns an error*.
This is leads to atomicity being violated - meaning that when a call
failed there would still be consequences to the memory in a subsequent
call.
@ureeves ureeves force-pushed the after_error_root branch 2 times, most recently from 0159afa to 29a05e1 Compare November 22, 2023 13:59
@ureeves ureeves marked this pull request as ready for review November 22, 2023 14:04
moCello
moCello approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piecrust/src/session.rs Show resolved Hide resolved
herr-seppia
herr-seppia approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ureeves ureeves merged commit f69d2b1 into main Nov 26, 2023
8 checks passed
@ureeves ureeves deleted the after_error_root branch November 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herr-seppia herr-seppia herr-seppia approved these changes

@moCello moCello moCello approved these changes

@miloszm miloszm Awaiting requested review from miloszm

@fed-franz fed-franz Awaiting requested review from fed-franz

@HDauven HDauven Awaiting requested review from HDauven

@Neotamandua Neotamandua Awaiting requested review from Neotamandua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent root after erroring calls
3 participants
@ureeves @moCello @herr-seppia