Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a HostQuery to take &mut Session #328

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Allow for a HostQuery to take &mut Session #328

merged 2 commits into from
Feb 13, 2024

Conversation

ureeves
Copy link
Member

@ureeves ureeves commented Feb 10, 2024

This will allow for downstream to make use of a Session while defining host functions, enabling contracts to be called during their execution.

Resolves: #327

@ureeves ureeves force-pushed the single-instance-per-call branch from c4b7675 to 2509e52 Compare February 12, 2024 12:30
@ureeves ureeves force-pushed the single-instance-per-call branch from 2509e52 to 1e7fbdf Compare February 12, 2024 12:45
@ureeves ureeves force-pushed the single-instance-per-call branch from 1e7fbdf to cfe6134 Compare February 12, 2024 15:30
@ureeves ureeves marked this pull request as ready for review February 12, 2024 15:45
Base automatically changed from single-instance-per-call to main February 12, 2024 16:29
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piecrust/src/vm.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will allow for downstream to make use of a `Session` while defining
host functions, enabling contracts to be called during their execution.

Resolves: #327
@ureeves ureeves merged commit 33395d8 into main Feb 13, 2024
6 checks passed
@ureeves ureeves deleted the session-host-fn branch February 13, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible for a HostQuery to use a Session
3 participants