piecrust: allow passing no argument when constructor exist #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were erroring out when providing no arguments for a constructor that takes no argument. This is undesirable since downstream does not necessarily know that the contract they deploy has a constructor. A contract that is provided an argument that it doesn't expect will still error at deploy time, during execution of the constructor. Resolves #316
ureeves
force-pushed
the
empty-argument-ctor-316
branch
from
c54b113 to
0dc4c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows passing no arguments even when a contract has a constructor.
If no argument is provided, the default used will be an empty byte vector. If the contract does require an argument, this will ensure that it errors during execution of the constructor, and thus error during deployment.
Resolves #316