Fix behavior on calling non-existent contracts #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2024 10:51
The function is intended to test calls to contracts that do not exist, whilst allowing for an easy check on the state.
ureeves
force-pushed
the
contract-does-not-exist
branch
from
352e0a2 to
62d2e5b
Compare
When the contract doesn't exist it never gets pushed onto the callstack, and instead results in a panic of the `c` import. This is clearly wrong and this commit addresses that by introducing a new error path does not revert the callstack.
ureeves
force-pushed
the
contract-does-not-exist
branch
from
62d2e5b to
90d80ae
Compare
miloszm
approved these changes
Aug 21, 2024
HDauven
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path when a contract calls another contract which does not exist was not handled, and would lead to a panic of the entire execution when it does. This PR fixes this by introducing a new error path in the
cimport that does not revert, and a newContractError::DoesNotExistvariant.