Change constructor to init(ializer) #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neotamandua
force-pushed
the
constructor_to_init
branch
from
fe0acb9 to
9257c3c
Compare
Neotamandua
force-pushed
the
constructor_to_init
branch
from
3ca0471 to
b80bab0
Compare
ureeves
approved these changes
Aug 21, 2024
- Add deprecation notice for constructor_arg
Neotamandua
force-pushed
the
constructor_to_init
branch
from
b80bab0 to
57e3711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasons for this change are mainly to improve consistency and also to correctly refer to the init function in the ContractDataBuilder.
Also, my understanding is that the init function is a generic function that is run once during deployment to execute any initialization logic. This implies to me that it can either execute init logic, including initializing data within a contract, but it does not construct the contract, an object, or the state (which already exists after compilation through the static mut STATE in most contracts).
I have also changed the naming within the example contracts. I initially suggested changing constructor_arg to initializer_arg, but opted for init_arg to avoid the z & s ambiguity in UK vs US English.