Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional "raw" calls #382

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Add additional "raw" calls #382

merged 6 commits into from
Sep 4, 2024

Conversation

ureeves
Copy link
Member

@ureeves ureeves commented Sep 4, 2024

This PR adds two other "raw" calls in piecrust-uplink, meant to allow the user to perform their own custom serialization in contract. emit_raw and feed_raw make sure that any serialization that the contract developer wishes to use is supported, as opposed to only rkyv, in the same way as call and call_raw already work.

Eduardo Leegwater Simões added 6 commits September 4, 2024 12:51
The new function, `emit_raw`, allows for emitting events that are *not*
serialized using `rkyv`. This effectively allows for user-defined
serialization of event data.
We expose the `emit_events_raw` which should function efectivelly the
same as `emit_events`, but uses the `emit_raw` function.
The new function, `feed_raw`, allows for emitting events that are *not*
serialized using `rkyv`. This effectively allows for user-defined
serialization of feed call data.
We expose the `feed_num_raw` which should function efectivelly the
same as `feed_num`, but uses the `feed_raw` function.
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ureeves ureeves merged commit a2e9c6d into main Sep 4, 2024
6 checks passed
@ureeves ureeves deleted the additional-raws branch September 4, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants