Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-wallet: Replace Card component #1655

Merged
merged 1 commit into from
Jul 5, 2024
Merged

web-wallet: Replace Card component #1655

merged 1 commit into from
Jul 5, 2024

Conversation

nortonandreev
Copy link
Contributor

@nortonandreev nortonandreev commented Apr 17, 2024 •
edited
Loading

Resolves #1650, Resolves #1295

@kieranhall kieranhall added the module:explorer Issues related to explorer module label Apr 29, 2024
@nortonandreev nortonandreev force-pushed the feature-1650 branch 2 times, most recently from 06c307e to 7fdcc2b Compare April 30, 2024 09:02
@nortonandreev nortonandreev marked this pull request as ready for review April 30, 2024 09:03
@nortonandreev nortonandreev self-assigned this Apr 30, 2024
@nortonandreev nortonandreev added module:web-wallet Issues related to web-wallet module and removed module:explorer Issues related to explorer module labels Apr 30, 2024
@nortonandreev nortonandreev requested review from deuch13, kieranhall and ascartabelli and removed request for deuch13 April 30, 2024 09:10
@nortonandreev nortonandreev force-pushed the feature-1650 branch 2 times, most recently from c967be7 to 5e787b2 Compare May 16, 2024 14:07
@nortonandreev nortonandreev force-pushed the feature-1650 branch 2 times, most recently from 6fb5de6 to 7902c55 Compare May 16, 2024 14:28
deuch13
deuch13 reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@deuch13 deuch13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment, everything else looks good.

web-wallet/src/lib/dusk/components/__tests__/Card.spec.js Show resolved Hide resolved
@kieranhall
Copy link
Member

Can this PR be worked on? It has been stale for some time now.

@nortonandreev nortonandreev force-pushed the feature-1650 branch 2 times, most recently from 7080c01 to b8a8b9f Compare July 3, 2024 08:44
@nortonandreev
Copy link
Contributor Author

Can this PR be worked on? It has been stale for some time now.

Ready for a re-review.

kieranhall
kieranhall approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@kieranhall kieranhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the future, we might want to merge some of the Card components together to make a more generic "workhorse" Card (in Duskit).

Thanks for making these changes.

@nortonandreev nortonandreev merged commit cad2129 into master Jul 5, 2024
8 checks passed
@nortonandreev nortonandreev deleted the feature-1650 branch July 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieranhall kieranhall kieranhall approved these changes

@ascartabelli ascartabelli Awaiting requested review from ascartabelli

@deuch13 deuch13 Awaiting requested review from deuch13

Assignees

@nortonandreev nortonandreev

Labels
module:web-wallet Issues related to web-wallet module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Wallet to Utilize Generic Card Variant Add gap options for the Card component
4 participants
@nortonandreev @kieranhall @ascartabelli @deuch13