Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create WorldMap component #1703

Merged
merged 1 commit into from
May 7, 2024
Merged

Create WorldMap component #1703

merged 1 commit into from
May 7, 2024

Conversation

deuch13
Copy link
Contributor

@deuch13 deuch13 commented May 1, 2024

Resolves #1671

@deuch13 deuch13 added the module:explorer Issues related to explorer module label May 1, 2024
@deuch13 deuch13 self-assigned this May 1, 2024
@deuch13 deuch13 changed the title Feature 1671 Create WorldMap component May 7, 2024
@deuch13 deuch13 marked this pull request as ready for review May 7, 2024 10:16
@nortonandreev
Copy link
Contributor

nortonandreev commented May 7, 2024 •
edited
Loading

Two small remarks:

  1. I don't like the way the Map gets displayed – it is possible to have some predefined width, so that the loading is a bit more pleasant?
Screen.Recording.2024-05-07.at.14.50.57.mov
  1. Check with @laremas, but I think the map is way too small. If it's up to me, I would probably have something like this:
Screenshot 2024-05-07 at 14 58 12

@deuch13 deuch13 closed this May 7, 2024
@deuch13 deuch13 reopened this May 7, 2024
nortonandreev
nortonandreev previously approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@nortonandreev nortonandreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left minor comments, nothing blocking! Great work, @deuch13! 💥

@deuch13 deuch13 force-pushed the feature-1671 branch 2 times, most recently from 462306c to 186b0e2 Compare May 7, 2024 13:27
@deuch13 deuch13 requested a review from nortonandreev May 7, 2024 13:39
@deuch13 deuch13 merged commit e703169 into master May 7, 2024
8 checks passed
@deuch13 deuch13 deleted the feature-1671 branch May 7, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nortonandreev nortonandreev nortonandreev approved these changes

@kieranhall kieranhall Awaiting requested review from kieranhall

@ascartabelli ascartabelli Awaiting requested review from ascartabelli

Assignees

@deuch13 deuch13

Labels
module:explorer Issues related to explorer module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

explorer: Create Map component
2 participants
@deuch13 @nortonandreev