explorer: integrate data stores and polling #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuch13
requested review from
nortonandreev,
kieranhall and
ascartabelli
and removed request for
nortonandreev and
kieranhall
ascartabelli
requested changes
May 13, 2024
explorer/src/lib/components/transactions-list/TransactionsList.svelte
Outdated
Show resolved
Hide resolved
explorer/src/lib/components/transactions-list/TransactionsList.svelte
Outdated
Show resolved
Hide resolved
explorer/src/lib/containers/statistics-panel/StatisticsPanel.svelte
Outdated
Show resolved
Hide resolved
|
I see an experience issue that was also present in the old Explorer and I personally find quite unpleasant: Screen.Recording.2024-05-13.at.14.54.52.movSometimes, a user needs to click twice on the ID to get redirected to the page. I have to check the code, but if it's related to the polling, maybe it will be better to first redirect the user to the page and then initialize the polling – so that there is no lag before the page navigation? Edit: NVM, in this case seems like it was due to my configuration. |
ascartabelli
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1694