Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: fix double scrollbar issue #1752

Merged
merged 1 commit into from
May 17, 2024
Merged

explorer: fix double scrollbar issue #1752

merged 1 commit into from
May 17, 2024

Conversation

deuch13
Copy link
Contributor

@deuch13 deuch13 commented May 15, 2024

Resolves: #1751

@deuch13 deuch13 added the module:explorer Issues related to explorer module label May 15, 2024
@deuch13 deuch13 self-assigned this May 15, 2024
@deuch13 deuch13 marked this pull request as ready for review May 17, 2024 11:27
@nortonandreev
Copy link
Contributor

nortonandreev commented May 17, 2024

An issue I am seeing is that I am not able to scroll unless I refresh the page. Happens on Chrome and Safari.

Screen.Recording.2024-05-17.at.15.22.14.mov

@deuch13
Copy link
Contributor Author

deuch13 commented May 17, 2024

Two things to raise. I might have misunderstood the problem, partially, as during the sync up my network was not perfect, so the screen sharing was lagging.

  1. I'm not sure I like this solution, as on mobile it is hard to access the latest transactions / all transactions CTA.

Screen.Recording.2024-05-17.at.15.15.59.mov
The user has to scroll down quite a lot to find out about the existence of the Transactions, as shown in the video, which is not ideal.

Some solutions I could think of:

  • Display less blocks/transactions on the home page when on mobile
  • On mobile, add buttons before the statistics pane for Transactions and Blocks – these can scroll to the section selected on the home page (where the CTA to show All Blocks / Transactions is visible)
  • Similar to the previous suggestion, but make it open the transactions / blocks page – this would mean for mobile the nav bar will need redesigning, so that blocks and transactions are not hidden in the hamburger menu. Then the hamburger icon can become a search icon and the current nav bar panel on mobile can be repurposed to be only used for the search on mobile.
  1. An issue I am seeing is that I am not able to scroll unless I refresh the page. Happens on Chrome and Safari.

Screen.Recording.2024-05-17.at.15.22.14.mov

I thinks it's best to treat the the first point you brought up in a separate issue. The second point I resolved in this PR.

@deuch13 deuch13 merged commit 229f43c into master May 17, 2024
8 checks passed
@deuch13 deuch13 deleted the feature-1751 branch May 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:explorer Issues related to explorer module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explorer: Fix double scrollbar on Blocks and Transactions pages
2 participants