Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: Support open-consensus-mode in event_loop #1962

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Conversation

goshawk-3
Copy link
Contributor

fixes #1907

@goshawk-3 goshawk-3 marked this pull request as ready for review July 11, 2024 08:53
herr-seppia
herr-seppia previously approved these changes Jul 18, 2024
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
A couple of comments to fix.

consensus/src/execution_ctx.rs Outdated Show resolved Hide resolved
consensus/src/execution_ctx.rs Outdated Show resolved Hide resolved
@herr-seppia herr-seppia requested a review from fed-franz July 22, 2024 13:08
@herr-seppia herr-seppia merged commit c76847c into master Jul 23, 2024
8 checks passed
@herr-seppia herr-seppia deleted the fix-1907 branch July 23, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not start over when reaching last iteration
3 participants