Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Check Certificate is Success Attestation #1985

Merged
merged 2 commits into from
Jul 18, 2024
Merged

node: Check Certificate is Success Attestation #1985

merged 2 commits into from
Jul 18, 2024

Conversation

herr-seppia
Copy link
Member

Additionally, improve verify_prev_block_cert performance:

  • Fetch the header instead of fetching the full block
  • Use the header hash instead of the block height

Resolves #1905

Base automatically changed from header_record to master July 18, 2024 09:33
- Fetch the header instead of fetching the full block
- Use the header hash instead of the block height
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit a5f7c3c into master Jul 18, 2024
8 checks passed
@herr-seppia herr-seppia deleted the fix-1905 branch July 18, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node: Check Certificate is Success Attestation
2 participants