Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Remove scale from icon buttons #1997

Closed
wants to merge 1 commit into from
Closed

Conversation

nortonandreev
Copy link
Contributor

Resolves #1996

@nortonandreev nortonandreev requested review from ascartabelli, kieranhall and deuch13 and removed request for ascartabelli July 22, 2024 13:18
@ascartabelli
Copy link
Contributor

I would close this unless @laremas had a change of mind as the scaling we agreed upon (with him) was fixed in this commit.

@nortonandreev
Copy link
Contributor Author

I would close this unless @laremas had a change of mind as the scaling we agreed upon (with him) was fixed in this commit.

It was not really fixed.

Screen.Recording.2024-07-22.at.18.11.03.mov

We had agreed that we don't need scaling on hover, the color change is enough.

cc: @laremas

@ascartabelli
Copy link
Contributor

I would close this unless @laremas had a change of mind as the scaling we agreed upon (with him) was fixed in this commit.

It was not really fixed.

We had agreed that we don't need scaling on hover, the color change is enough.

It was fixed as that PR was made after checking with him.

I have nothing against removing the scale on hover, but it's @laremas decision anyway.

@laremas
Copy link
Member

laremas commented Jul 24, 2024

Nothing to add from my side, can be closed

@kieranhall kieranhall closed this Sep 10, 2024
@nortonandreev nortonandreev deleted the feature-1996 branch October 7, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove scale transition from icon buttons
4 participants