Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1884 - contract ID generation mechanism #2003

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Issue 1884 - contract ID generation mechanism #2003

merged 2 commits into from
Jul 26, 2024

Conversation

miloszm
Copy link
Contributor

@miloszm miloszm commented Jul 23, 2024 •
edited
Loading

contract ID generation mechanism

extends current deployment transaction format to support contract nonce

implements issue #1884

@miloszm miloszm force-pushed the issue-1884 branch 10 times, most recently from 2c06c85 to 15b009c Compare July 24, 2024 13:01
@miloszm miloszm marked this pull request as ready for review July 24, 2024 13:04
ureeves
ureeves requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the contract ID generation needs to be in rusk-abi? It seems to me that it is only used - and will only ever be used - in rusk proper.

execution-core/src/transfer.rs Outdated Show resolved Hide resolved
rusk-abi/src/lib.rs Outdated Show resolved Hide resolved
fed-franz
fed-franz reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced by how the contract ID is calcualted. Also, I think some things should be managed in rusk, rather then piecrust (for instance, the nonce check).

rusk/src/lib/chain/rusk.rs Show resolved Hide resolved
@miloszm miloszm requested a review from ZER0 July 25, 2024 09:07
@miloszm miloszm force-pushed the issue-1884 branch 6 times, most recently from 3f54ef8 to 57308ad Compare July 25, 2024 13:27
@miloszm miloszm requested review from ureeves and fed-franz July 25, 2024 13:34
ureeves
ureeves approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rusk/src/lib/gen_id.rs Show resolved Hide resolved
@miloszm miloszm merged commit e7c0f11 into master Jul 26, 2024
8 checks passed
@miloszm miloszm deleted the issue-1884 branch July 26, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@moCello moCello Awaiting requested review from moCello

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

@ZER0 ZER0 Awaiting requested review from ZER0

@fed-franz fed-franz Awaiting requested review from fed-franz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miloszm @fed-franz @moCello @ureeves