Add BLS signature cache #2005
Merged
Add BLS signature cache #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
moCello,
goshawk-3 and
herr-seppia
ureeves
force-pushed
the
cache-bls-signatures
branch
from
c9914ca to
6f3de4d
Compare
Cache definition placed in a different file, and abstracted away with a macro, allowing one to generate different cache types according to in-code parameters. This macro is then leveraged to generate both Plonk proof and BLS signature caches, which are then subsequently used in our code. To slightly improve the implementation of both, the hash used as a cache key is now computed using the argument buffer contents, as opposed to the deserialized parameters. This allows for a cleaner and more performant implementation. See-also: #1984
ureeves
force-pushed
the
cache-bls-signatures
branch
from
6f3de4d to
6ade1ec
Compare
HDauven
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache definition placed in a different file, and abstracted away with a macro, allowing one to generate different cache types according to in-code parameters.
This macro is then leveraged to generate both Plonk proof and BLS signature caches, which are then subsequently used in our code.
To slightly improve the implementation of both, the hash used as a cache key is now computed using the argument buffer contents, as opposed to the deserialized parameters. This allows for a cleaner and more performant implementation.
See-also: #1984