Fix "freed while in use" #2006
Merged
Fix "freed while in use" #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 23, 2024 21:12
The `tokio::select!` macro seems to have changed in such a way as to not work well with the syntax we used, and in the process breaking their crate even if the version doesn't indicate it under semver rules. This commit addresses this by changing the syntax to something the macro understands.
HDauven
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tokio::select!macro seems to have broken its syntax, even if not reflected in thetokioversion. This PR fixes our syntax to comply withtokio.We also ensure only one version of
tokiois included at a time, avoiding longer compilation times.