Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

w3sper: Add an API to fetch stake information for the given account(s) #2943

Merged
merged 1 commit into from
Nov 12, 2024
Merged

w3sper: Add an API to fetch stake information for the given account(s) #2943

merged 1 commit into from
Nov 12, 2024

Conversation

ZER0
Copy link
Contributor

@ZER0 ZER0 commented Nov 12, 2024

  • Remove unnecessary async from BookEntry#balance
  • Add BookEntry#stakeInfo() method
  • Add Bookkeeper#stakeInfo() method
  • Add Contracts#stakeContract getter
  • Add private StakeAmount class in AccountSyncer
  • Add private StakeInfo class in AccountSyncer
  • Add AccountSyncer#stakes method
  • Change test Treasury to fetch and store stakes information
  • Add tests/stake_test.js

Resolves #2942

@ZER0 ZER0 force-pushed the w3sper-stake-info-2942 branch from 8fa26ea to c030284 Compare November 12, 2024 14:06
ascartabelli
ascartabelli previously approved these changes Nov 12, 2024
View reviewed changes
@ZER0
w3sper: Add an API to fetch stake information for the given account(s)
ebbdbb9 
- Remove unnecessary `async` from `BookEntry#balance`
- Add `BookEntry#stakeInfo()` method
- Add `Bookkeeper#stakeInfo()` method
- Add `Contracts#stakeContract` getter
- Add private `StakeAmount` class in `AccountSyncer`
- Add private `StakeInfo` class in `AccountSyncer`
- Add `AccountSyncer#stakes` method
- Change test Treasury to fetch and store stakes information
- Add `tests/stake_test.js`

Resolves #2942
@ZER0 ZER0 force-pushed the w3sper-stake-info-2942 branch from c030284 to ebbdbb9 Compare November 12, 2024 14:23
@ZER0 ZER0 merged commit a758ec3 into master Nov 12, 2024
12 checks passed
@ZER0 ZER0 deleted the w3sper-stake-info-2942 branch November 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascartabelli ascartabelli ascartabelli approved these changes

@kieranhall kieranhall Awaiting requested review from kieranhall

@welf welf Awaiting requested review from welf

@nortonandreev nortonandreev Awaiting requested review from nortonandreev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

w3sper: Add an API to fetch stake information for the given account(s)
2 participants
@ZER0 @ascartabelli