wallet-core: expose staking capabilities via FFI #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `moonlight_stake` in FFI module - Add `moonlight_unstake` in FFI module - Add `moonlight_stake_reward` in FFI module - Add `ErrorCode::ContractCallError` - Change the visibility of `stake_reward_to_moonlight` to `pub(crate)` - Change the visibility of `unstake_to_moonlight` to `pub(crate)` Resolves #2955
|
While stake and unstake are currently tested and working as expected, the stake reward function is not yet covered. Please pay extra attention when reviewing that part to spot any potential issues. In the worst-case scenario, we can address any problems in a follow-up PR. Merging this one will unblock the web apps team and allow them to implement at least the other two methods. |
moCello
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moonlight_stakein FFI modulemoonlight_unstakein FFI modulemoonlight_stake_rewardin FFI moduleErrorCode::ContractCallErrorstake_reward_to_moonlighttopub(crate)unstake_to_moonlighttopub(crate)Resolves #2955