Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3sper: Add withdraw stake's reward method #2968

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ZER0
Copy link
Contributor

@ZER0 ZER0 commented Nov 13, 2024

  • Add WithdrawStakeRewardTransfer class in transaction
  • Add BookEntry#withdraw method
  • Add withdraw function in protocol-driver
  • Add withdraws tests

Resolves #2952

@ZER0 ZER0 force-pushed the w3sper-reward-2952 branch from 2ddef12 to 641ab0c Compare November 13, 2024 21:07
@ZER0 ZER0 changed the title wip w3sper: Add withdraw stake's reward method Nov 13, 2024
@ZER0 ZER0 marked this pull request as ready for review November 13, 2024 21:07
Copy link
Contributor

@ascartabelli ascartabelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks in error messages, good to merge otherwise.

w3sper.js/src/transaction.js Outdated Show resolved Hide resolved
w3sper.js/src/transaction.js Outdated Show resolved Hide resolved
- Add `WithdrawStakeRewardTransfer` class in `transaction`
- Add `BookEntry#withdraw` method
- Add `withdraw` function in `protocol-driver`
- Add withdraws tests

Resolves #2952
@ZER0 ZER0 force-pushed the w3sper-reward-2952 branch from 641ab0c to 4922c5d Compare November 14, 2024 09:23
@ZER0 ZER0 merged commit 0784b82 into w3sper-stake-unstake Nov 14, 2024
12 checks passed
@ZER0 ZER0 deleted the w3sper-reward-2952 branch November 14, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants