Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix event_loop #3157

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Refactor and fix event_loop #3157

merged 6 commits into from
Dec 20, 2024

Conversation

fed-franz
Copy link
Contributor

@fed-franz fed-franz commented Dec 10, 2024 •
edited
Loading

  • Fix event_loop to start Open Consensus Mode at the end of the last Ratification step (instead of the beginning of the last iteration)

Refactors:

  • rename last_step_running to is_last_step
  • delete QuorumMsgSender (replace send_quorum with try_send)
  • order messages in message.rs
  • improve logs

@fed-franz fed-franz self-assigned this Dec 10, 2024
@fed-franz fed-franz marked this pull request as ready for review December 10, 2024 11:36
@fed-franz fed-franz force-pushed the refactor_execution_ctx branch 5 times, most recently from 12f543a to f0b6d93 Compare December 20, 2024 12:30
@fed-franz fed-franz changed the title Refactor execution ctx Refactor and fix event_loop Dec 20, 2024
@fed-franz fed-franz requested a review from autholykos December 20, 2024 13:45
@fed-franz fed-franz force-pushed the refactor_execution_ctx branch from f0b6d93 to d590d60 Compare December 20, 2024 14:03
herr-seppia
herr-seppia approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fed-franz fed-franz merged commit 9099531 into master Dec 20, 2024
16 checks passed
@fed-franz fed-franz deleted the refactor_execution_ctx branch December 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herr-seppia herr-seppia herr-seppia approved these changes

@autholykos autholykos Awaiting requested review from autholykos

Assignees

@fed-franz fed-franz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fed-franz @herr-seppia