Merge pull request #100 from dusk-network/fix_tx_hash

Use .to_bytes to get the blsscalar in little endian
dusk-network · Dec 23, 2023 · e09e3e7 · e09e3e7
2 parents e083cd1 + e64107f
commit e09e3e7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/assets/dusk_wallet_core.wasm b/assets/dusk_wallet_core.wasm
diff --git a/dusk-wallet-core-0.21.0.wasm b/dusk-wallet-core-0.21.0.wasm
diff --git a/src/compat/tx.rs b/src/compat/tx.rs
@@ -12,6 +12,7 @@ use crate::{
 };
 
 use alloc::{
+    format,
     string::{String, ToString},
     vec::Vec,
 };
@@ -225,7 +226,7 @@ pub fn get_history(args: i32, len: i32) -> i64 {
                     block_height: note_data.block_height,
                     amount: note_amount - inputs_amount,
                     fee: gas_spent * t.fee().gas_price,
-                    id: hash_to_find.to_string(),
+                    id: transaction_hash(hash_to_find),
                 }),
             }
         } else {
@@ -256,6 +257,18 @@ pub fn get_history(args: i32, len: i32) -> i64 {
     utils::into_ptr(types::GetHistoryResponse { history: ret })
 }
 
+fn transaction_hash(hash: BlsScalar) -> String {
+    let mut f = String::new();
+
+    let tmp = hash.to_bytes();
+
+    for &b in tmp.iter() {
+        f.push_str(&format!("{:02x}", b))
+    }
+
+    f
+}
+
 /// Serialize a unprovenTx we recieved from the wallet-core
 /// this is copied from old wallet-core (0.20.0-piecrust.0.6)
 fn utx_to_var_bytes(