Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename malloc to allocate to fix conflict in windows #83

Merged
merged 2 commits into from
Sep 25, 2023
Merged

rename malloc to allocate to fix conflict in windows #83

merged 2 commits into from
Sep 25, 2023

Conversation

Daksh14
Copy link
Contributor

@Daksh14 Daksh14 commented Sep 24, 2023 •
edited
Loading

Closes #82

@Daksh14 Daksh14 requested review from vlopes11 and HDauven September 24, 2023 00:46
HDauven
HDauven approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but check with @artifex11 as well.

vlopes11
vlopes11 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Daksh14 Daksh14 merged commit a925ead into main Sep 25, 2023
4 checks passed
@Daksh14 Daksh14 deleted the rename_malloc branch September 25, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDauven HDauven HDauven approved these changes

@vlopes11 vlopes11 vlopes11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malloc linking error on Windows
3 participants
@Daksh14 @vlopes11 @HDauven