feat: VOL-4754 increase static analysis levels #124
ci.yaml
on: pull_request
Matrix: security / Snyk PHP Scan
Matrix: static-analysis / php-codesniffer
Matrix: static-analysis / phpstan
Matrix: static-analysis / psalm
Matrix: tests / tests
Annotations
26 errors and 12 warnings
static-analysis / PHP-CodeSniffer - 7.4 - prefer-lowest
Process completed with exit code 2.
|
tests / PHP test 7.4
Process completed with exit code 1.
|
static-analysis / PHP-CodeSniffer - 7.4 - prefer-stable
The job was canceled because "prefer-lowest" failed.
|
static-analysis / PHP-CodeSniffer - 7.4 - prefer-stable
The operation was canceled.
|
MoreSpecificImplementedParamType:
src/Filter/Postcode.php#L26
src/Filter/Postcode.php:26:28: MoreSpecificImplementedParamType: Argument 1 of Dvsa\Olcs\Transfer\Filter\Postcode::filter has the more specific type 'string', expecting 'mixed' as defined by Laminas\Filter\FilterInterface::filter (see https://psalm.dev/140)
|
ParamNameMismatch:
src/Filter/Vrm.php#L43
src/Filter/Vrm.php:43:28: ParamNameMismatch: Argument 1 of Dvsa\Olcs\Transfer\Filter\Vrm::filter has wrong name $input, expecting $value as defined by Laminas\Filter\FilterInterface::filter (see https://psalm.dev/230)
|
MoreSpecificImplementedParamType:
src/Filter/Vrm.php#L43
src/Filter/Vrm.php:43:28: MoreSpecificImplementedParamType: Argument 1 of Dvsa\Olcs\Transfer\Filter\Vrm::filter has the more specific type 'string', expecting 'mixed' as defined by Laminas\Filter\FilterInterface::filter (see https://psalm.dev/140)
|
InvalidReturnType:
src/Service/CacheEncryption.php#L325
src/Service/CacheEncryption.php:325:16: InvalidReturnType: The declared return type 'null|string' for Dvsa\Olcs\Transfer\Service\CacheEncryption::decrypt is incorrect, got 'bool|null|string' (see https://psalm.dev/011)
|
InvalidReturnStatement:
src/Service/CacheEncryption.php#L334
src/Service/CacheEncryption.php:334:16: InvalidReturnStatement: The inferred type 'bool|string' does not match the declared return type 'null|string' for Dvsa\Olcs\Transfer\Service\CacheEncryption::decrypt (see https://psalm.dev/128)
|
LessSpecificImplementedReturnType:
src/Util/ArrayInput.php#L90
src/Util/ArrayInput.php:90:16: LessSpecificImplementedReturnType: The inherited return type 'array<array-key, string>' for Laminas\InputFilter\InputInterface::getMessages is more specific than the implemented return type for Dvsa\Olcs\Transfer\Util\ArrayInput::getmessages 'array<array-key, mixed>' (see https://psalm.dev/166)
|
LessSpecificImplementedReturnType:
src/Util/ArrayInput.php#L90
src/Util/ArrayInput.php:90:16: LessSpecificImplementedReturnType: The inherited return type 'array<array-key, string>' for Laminas\InputFilter\Input::getMessages is more specific than the implemented return type for Dvsa\Olcs\Transfer\Util\ArrayInput::getmessages 'array<array-key, mixed>' (see https://psalm.dev/166)
|
MoreSpecificImplementedParamType:
src/Util/StructuredInput.php#L135
src/Util/StructuredInput.php:135:37: MoreSpecificImplementedParamType: Argument 1 of Dvsa\Olcs\Transfer\Util\StructuredInput::setErrorMessage has the more specific type 'string', expecting 'null|string' as defined by Laminas\InputFilter\InputInterface::setErrorMessage (see https://psalm.dev/140)
|
InvalidNullableReturnType:
src/Util/StructuredInput.php#L242
src/Util/StructuredInput.php:242:16: InvalidNullableReturnType: The declared return type 'string' for Dvsa\Olcs\Transfer\Util\StructuredInput::getErrorMessage is not nullable, but 'null|string' contains null (see https://psalm.dev/144)
|
NullableReturnStatement:
src/Util/StructuredInput.php#L246
src/Util/StructuredInput.php:246:16: NullableReturnStatement: The declared return type 'string' for Dvsa\Olcs\Transfer\Util\StructuredInput::getErrorMessage is not nullable, but the function returns 'null|string' (see https://psalm.dev/139)
|
tests / PHP test 7.4
Process completed with exit code 1.
|
static-analysis / Psalm - 7.4 - prefer-stable
The job was canceled because "prefer-lowest" failed.
|
MoreSpecificImplementedParamType:
src/Filter/Postcode.php#L26
src/Filter/Postcode.php:26:28: MoreSpecificImplementedParamType: Argument 1 of Dvsa\Olcs\Transfer\Filter\Postcode::filter has the more specific type 'string', expecting 'mixed' as defined by Laminas\Filter\FilterInterface::filter (see https://psalm.dev/140)
|
ParamNameMismatch:
src/Filter/Vrm.php#L43
src/Filter/Vrm.php:43:28: ParamNameMismatch: Argument 1 of Dvsa\Olcs\Transfer\Filter\Vrm::filter has wrong name $input, expecting $value as defined by Laminas\Filter\FilterInterface::filter (see https://psalm.dev/230)
|
MoreSpecificImplementedParamType:
src/Filter/Vrm.php#L43
src/Filter/Vrm.php:43:28: MoreSpecificImplementedParamType: Argument 1 of Dvsa\Olcs\Transfer\Filter\Vrm::filter has the more specific type 'string', expecting 'mixed' as defined by Laminas\Filter\FilterInterface::filter (see https://psalm.dev/140)
|
InvalidReturnType:
src/Service/CacheEncryption.php#L325
src/Service/CacheEncryption.php:325:16: InvalidReturnType: The declared return type 'null|string' for Dvsa\Olcs\Transfer\Service\CacheEncryption::decrypt is incorrect, got 'bool|null|string' (see https://psalm.dev/011)
|
InvalidReturnStatement:
src/Service/CacheEncryption.php#L334
src/Service/CacheEncryption.php:334:16: InvalidReturnStatement: The inferred type 'bool|string' does not match the declared return type 'null|string' for Dvsa\Olcs\Transfer\Service\CacheEncryption::decrypt (see https://psalm.dev/128)
|
LessSpecificImplementedReturnType:
src/Util/ArrayInput.php#L90
src/Util/ArrayInput.php:90:16: LessSpecificImplementedReturnType: The inherited return type 'array<array-key, string>' for Laminas\InputFilter\InputInterface::getMessages is more specific than the implemented return type for Dvsa\Olcs\Transfer\Util\ArrayInput::getmessages 'array<array-key, mixed>' (see https://psalm.dev/166)
|
LessSpecificImplementedReturnType:
src/Util/ArrayInput.php#L90
src/Util/ArrayInput.php:90:16: LessSpecificImplementedReturnType: The inherited return type 'array<array-key, string>' for Laminas\InputFilter\Input::getMessages is more specific than the implemented return type for Dvsa\Olcs\Transfer\Util\ArrayInput::getmessages 'array<array-key, mixed>' (see https://psalm.dev/166)
|
MoreSpecificImplementedParamType:
src/Util/StructuredInput.php#L135
src/Util/StructuredInput.php:135:37: MoreSpecificImplementedParamType: Argument 1 of Dvsa\Olcs\Transfer\Util\StructuredInput::setErrorMessage has the more specific type 'string', expecting 'null|string' as defined by Laminas\InputFilter\InputInterface::setErrorMessage (see https://psalm.dev/140)
|
InvalidNullableReturnType:
src/Util/StructuredInput.php#L242
src/Util/StructuredInput.php:242:16: InvalidNullableReturnType: The declared return type 'string' for Dvsa\Olcs\Transfer\Util\StructuredInput::getErrorMessage is not nullable, but 'null|string' contains null (see https://psalm.dev/144)
|
NullableReturnStatement:
src/Util/StructuredInput.php#L246
src/Util/StructuredInput.php:246:16: NullableReturnStatement: The declared return type 'string' for Dvsa\Olcs\Transfer\Util\StructuredInput::getErrorMessage is not nullable, but the function returns 'null|string' (see https://psalm.dev/139)
|
static-analysis / PHP-CodeSniffer - 7.4 - prefer-lowest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
tests / PHP test 7.4
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
static-analysis / Psalm - 7.4 - prefer-lowest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
tests / PHP test 7.4
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
static-analysis / PHPStan - 7.4 - prefer-lowest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
security / Snyk PHP Scan (7.4, prefer-stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, octokit/[email protected], github/codeql-action/upload-sarif@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
security / Snyk PHP Scan (7.4, prefer-stable)
Unexpected input(s) 'owner', 'repo', 'graphqlEndpoint', 'token', valid inputs are ['query', 'mediaType', 'variables']
|
security / Snyk PHP Scan (7.4, prefer-stable)
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
|
security / Snyk PHP Scan (7.4, prefer-lowest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, octokit/[email protected], github/codeql-action/upload-sarif@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
security / Snyk PHP Scan (7.4, prefer-lowest)
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
|
security / Snyk PHP Scan (7.4, prefer-lowest)
Unexpected input(s) 'owner', 'repo', 'graphqlEndpoint', 'token', valid inputs are ['query', 'mediaType', 'variables']
|
static-analysis / PHPStan - 7.4 - prefer-stable
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|