feat: ApplicationLicenceList ByOrganisation now uses OrganisationOptional #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadedvsa
approved these changes
Feb 6, 2024
JoshuaLicense
pushed a commit
that referenced
this pull request
Feb 16, 2024
* feat: List conversations for self serve messaging (#24) * feat: Query Applications / Licences (#12) * WIP * Endpoint prep for ByOrg * Update Trait usage * Remove backend route for query without handler * Remove unused query and route --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Messaging subjects (#26) * Backend route & query * Class name & Namespace * Import --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Disable/enabling messaging (#28) * feat: Added Create Conversation Command (#29) * Backend route & query * Class name & Namespace * feat: Added Create Message command * chore: added strict types --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: ApplicationLicenceList ByOrganisation now uses OrganisationOptional (#30) * feat: Msg ApplicationLicenceList ByOrganisation now uses OrganisationOptional * chore: added unit test for query * fix: Fixed existing unit test using incorrect property * feat: Task messaging filter (home page) (#31) * fix: Add missing messaging flag for backend. (#32) * fix: CreateTaskTest (#36) --------- Co-authored-by: Wade Womersley <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: Saul Wilcox <[email protected]>
hobbyhacker0
added a commit
that referenced
this pull request
Feb 22, 2024
* feat: List conversations for self serve messaging (#24) * feat: Query Applications / Licences (#12) * WIP * Endpoint prep for ByOrg * Update Trait usage * Remove backend route for query without handler * Remove unused query and route --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Messaging subjects (#26) * Backend route & query * Class name & Namespace * Import --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: Disable/enabling messaging (#28) * feat: Added Create Conversation Command (#29) * Backend route & query * Class name & Namespace * feat: Added Create Message command * chore: added strict types --------- Co-authored-by: Saul Wilcox <[email protected]> * feat: ApplicationLicenceList ByOrganisation now uses OrganisationOptional (#30) * feat: Msg ApplicationLicenceList ByOrganisation now uses OrganisationOptional * chore: added unit test for query * fix: Fixed existing unit test using incorrect property * feat: Task messaging filter (home page) (#31) * fix: Add missing messaging flag for backend. (#32) * fix: CreateTaskTest (#36) * WIP --------- Co-authored-by: Wade Womersley <[email protected]> Co-authored-by: Saul Wilcox <[email protected]> Co-authored-by: James Wragg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
Messaging\ApplicationLicenceList\ByOrganisationto useOrganisationOptionalinstead ofOrganisation.The consumer on olcs-backend will fall back to using current identity's organisation if one is not set.
This gives greater flexibility for this query and means self-service can call this (for current user context awareness) and olcs-internal can continue to use this (when targeting organisations/licences/applications) as they have no organisation context.
Fixed existing unit test defining incorrect property on
Conversations\ByOrganisation.Related issue: VOL-4380
Before submitting (or marking as "ready for review")