Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing messaging flag for backend. #32

Merged

Conversation

wadedvsa
Copy link
Contributor

@wadedvsa wadedvsa commented Feb 9, 2024

Description

Last TM letter batch job erroring due to CreateTask::getMessaging() method

Related issue: VOL-4975

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@wadedvsa wadedvsa merged commit 48253e0 into project/messaging Feb 9, 2024
9 of 11 checks passed
@wadedvsa wadedvsa deleted the bugfix/VOL-4975-missing-parameter-messaging branch February 9, 2024 14:53
JoshuaLicense pushed a commit that referenced this pull request Feb 16, 2024
* feat: List conversations for self serve messaging (#24)

* feat: Query Applications / Licences (#12)

* WIP

* Endpoint prep for ByOrg

* Update Trait usage

* Remove backend route for query without handler

* Remove unused query and route

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Messaging subjects (#26)

* Backend route & query

* Class name & Namespace

* Import

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Disable/enabling messaging (#28)

* feat: Added Create Conversation Command (#29)

* Backend route & query

* Class name & Namespace

* feat: Added Create Message command

* chore: added strict types

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: ApplicationLicenceList ByOrganisation now uses OrganisationOptional (#30)

* feat: Msg ApplicationLicenceList ByOrganisation now uses OrganisationOptional

* chore: added unit test for query

* fix: Fixed existing unit test using incorrect property

* feat: Task messaging filter (home page) (#31)

* fix: Add missing messaging flag for backend. (#32)

* fix: CreateTaskTest (#36)

---------

Co-authored-by: Wade Womersley <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
hobbyhacker0 added a commit that referenced this pull request Feb 22, 2024
* feat: List conversations for self serve messaging (#24)

* feat: Query Applications / Licences (#12)

* WIP

* Endpoint prep for ByOrg

* Update Trait usage

* Remove backend route for query without handler

* Remove unused query and route

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Messaging subjects (#26)

* Backend route & query

* Class name & Namespace

* Import

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: Disable/enabling messaging (#28)

* feat: Added Create Conversation Command (#29)

* Backend route & query

* Class name & Namespace

* feat: Added Create Message command

* chore: added strict types

---------

Co-authored-by: Saul Wilcox <[email protected]>

* feat: ApplicationLicenceList ByOrganisation now uses OrganisationOptional (#30)

* feat: Msg ApplicationLicenceList ByOrganisation now uses OrganisationOptional

* chore: added unit test for query

* fix: Fixed existing unit test using incorrect property

* feat: Task messaging filter (home page) (#31)

* fix: Add missing messaging flag for backend. (#32)

* fix: CreateTaskTest (#36)

* WIP

---------

Co-authored-by: Wade Womersley <[email protected]>
Co-authored-by: Saul Wilcox <[email protected]>
Co-authored-by: James Wragg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants