refactor: Remove unused param from export CMDs

dvsa · Oct 3, 2024 · 44c8c4c · 44c8c4c
1 parent 3ef329f
commit 44c8c4c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 13 deletions.
diff --git a/app/api/test/module/Cli/src/Command/Batch/DataDvaNiExportCommandTest.php b/app/api/test/module/Cli/src/Command/Batch/DataDvaNiExportCommandTest.php
@@ -22,29 +22,25 @@ protected function getCommandDTOs()
     {
         return [
             DataDvaNiExport::create([
-                'reportName' => 'exampleReport',
-                'path' => '/path/to/save'
+                'reportName' => 'exampleReport'
             ]),
         ];
     }
 
     public function testExecuteSuccess()
     {
         $params = [
-            'reportName' => 'exampleReport',
-            'path' => '/path/to/save',
+            'reportName' => 'exampleReport'
         ];
 
         $this->mockCommandHandlerManager->expects($this->once())
             ->method('handleCommand')
             ->with($this->callback(fn($command) => $command instanceof DataDvaNiExport
-                && $command->getReportName() === $params['reportName']
-                && $command->getPath() === $params['path']))
+                && $command->getReportName() === $params['reportName']))
             ->willReturn(new Result());
 
         $this->executeCommand([
-            '--report-name' => $params['reportName'],
-            '--path' => $params['path'],
+            '--report-name' => $params['reportName']
         ]);
     }
 }
diff --git a/app/api/test/module/Cli/src/Command/Batch/DataGovUkExportCommandTest.php b/app/api/test/module/Cli/src/Command/Batch/DataGovUkExportCommandTest.php
@@ -10,7 +10,6 @@ class DataGovUkExportCommandTest extends AbstractBatchCommandCases
 {
     protected $additionalArguments = [
         '--report-name' => 'govReport',
-        '--path' => '/gov/path/to/save',
     ];
 
     protected function getCommandClass()
@@ -27,8 +26,7 @@ protected function getCommandDTOs()
     {
         return [
             DataGovUkExport::create([
-                'reportName' => $this->additionalArguments['--report-name'],
-                'path' => $this->additionalArguments['--path']
+                'reportName' => $this->additionalArguments['--report-name']
             ])
         ];
     }

diff --git a/app/api/test/module/Cli/src/Domain/Command/DataDvaNiExportTest.php b/app/api/test/module/Cli/src/Domain/Command/DataDvaNiExportTest.php
@@ -20,6 +20,5 @@ public function test()
         $sut = DataDvaNiExport::create($params);
 
         static::assertEquals('unit_ReportName', $sut->getReportName());
-        static::assertEquals('unit_Path', $sut->getPath());
     }
 }
diff --git a/app/api/test/module/Cli/src/Domain/Command/DataGovUkExportTest.php b/app/api/test/module/Cli/src/Domain/Command/DataGovUkExportTest.php
@@ -21,6 +21,5 @@ public function test()
         $sut = DataGovUkExport::create($params);
 
         static::assertEquals('unit_ReportName', $sut->getReportName());
-        static::assertEquals('unit_Path', $sut->getPath());
     }
 }