Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security scanning on CI workflow #112

Merged
merged 91 commits into from
May 20, 2024

Conversation

gabrielg2020
Copy link
Contributor

@gabrielg2020 gabrielg2020 commented May 16, 2024

Description

Adding security scanning to CI workflow.

Related issue: VOL-5354

Scanning List

  • Application dependencies - Snyk
  • Terraform - Trivy

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@gabrielg2020 gabrielg2020 self-assigned this May 16, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@gabrielg2020 gabrielg2020 marked this pull request as ready for review May 20, 2024 09:32
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/security-app.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/security-terraform.yaml Outdated Show resolved Hide resolved
infra/docker/internal/Dockerfile Outdated Show resolved Hide resolved
@JoshuaLicense JoshuaLicense merged commit 2832f47 into main May 20, 2024
15 checks passed
@JoshuaLicense JoshuaLicense deleted the add-security-scanning-to-ci-VOL-5354 branch May 20, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants