Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Consultant Administrator option to add users page #363

Merged
merged 19 commits into from
Oct 9, 2024
Merged

feat: add Consultant Administrator option to add users page #363

merged 19 commits into from
Oct 9, 2024

Conversation

gabrielg2020
Copy link
Contributor

@gabrielg2020 gabrielg2020 commented Oct 2, 2024 •
edited
Loading

Description

Add Consultant Administrator option to add users page.

Related issue: VOL-4706

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@gabrielg2020 gabrielg2020 mentioned this pull request Oct 2, 2024
Merged
4 tasks
@gabrielg2020 gabrielg2020 marked this pull request as ready for review October 3, 2024 15:06
@gabrielg2020 gabrielg2020 requested review from ilindsay, fibble and a team as code owners October 3, 2024 15:06
@gabrielg2020
chore: removed php.xml
9bdfa7e 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020 gabrielg2020 marked this pull request as draft October 4, 2024 09:28
@gabrielg2020 gabrielg2020 marked this pull request as ready for review October 7, 2024 15:36
@gabrielg2020 gabrielg2020 marked this pull request as draft October 7, 2024 15:36
@gabrielg2020 gabrielg2020 marked this pull request as ready for review October 8, 2024 14:53
fibble
fibble previously approved these changes Oct 9, 2024
View reviewed changes
@jerotire
Copy link
Contributor

jerotire commented Oct 9, 2024 •
edited
Loading

Looks okay @gabrielg2020 - Have merged and published the olcs-transfer, so you need to do a composer update olcs/olcs-transfer and commit the lock. dvsa/olcs-transfer#94

@gabrielg2020 gabrielg2020 merged commit 9703d68 into main Oct 9, 2024
25 checks passed
@gabrielg2020 gabrielg2020 deleted the 4706-adding-consultant-adim-to-add-user-page branch October 9, 2024 14:14
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerotire jerotire jerotire approved these changes

@fibble fibble fibble approved these changes

@ilindsay ilindsay Awaiting requested review from ilindsay ilindsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielg2020 @jerotire @fibble @sdh100shaun