Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add/manage user TC role hidden when TC toggle disabled #393

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix: add/manage user TC role hidden when TC toggle disabled #393

merged 3 commits into from
Oct 17, 2024

Conversation

jerotire
Copy link
Contributor

@jerotire jerotire commented Oct 17, 2024 •
edited
Loading

Description

Ensures the Transport Consultant role is hidden from Add/Manage Users page when the feature toggle transport_consultant_role is disabled

Related issue: https://dvsa.atlassian.net/browse/VOL-4706

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@jerotire jerotire requested review from ilindsay, fibble and a team as code owners October 17, 2024 13:52
@fibble fibble merged commit 02aa445 into main Oct 17, 2024
19 checks passed
@fibble fibble deleted the fix/add-manage-user-tc-role-hidden-on-toggle branch October 17, 2024 14:32
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilindsay ilindsay ilindsay approved these changes

@fibble fibble fibble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerotire @fibble @ilindsay