This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
[FIX] Bypass cookie validation #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 18, 2017
| # | ||
| ###unless domains_match cookie_host, uri | ||
| ### errors << 'Domain is inappropriate based on request URI hostname' | ||
| ###end |
There was a problem hiding this comment.
Missing space after #.
| ### | ||
| # MonkeyPatch | ||
| # | ||
| ###unless domains_match cookie_host, uri |
There was a problem hiding this comment.
Missing space after #.
pre
added a commit
to smartlyio/cookiejar
that referenced
this pull request
May 17, 2018
There has been an open issue in cookiejar Gem since 2014. The project seems unmaintained, but it's used by the faye gem. References: * restforce/restforce#120 * dwaite#19 * dwaite#23
|
@dwaite Is this still maintained? This seems like a reasonable PR and is something our organization needs. |
|
FYI I just raised #35 that fixes this in a standards-compliant way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monkey patch for this issue: #19