Check if server is nil before passing pointer to go-keyring #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running into an issue that appears to be related to zalando/go-keyring#88, which I describe in zalando/go-keyring#88 (comment). The gist of the issue is that an incompatibility between go-keyring and KeepassXC causes a segfault in the
SetServerPassword
method as theServerConfig
isn't properly initialized.As there's currently no ETA for the upstream issue being fixed, I propose the following solution to prevent a segfault in the event that this or any other issue crops up which causes the
ServerConfig
to benil
. SincetrySetPasswordAndConnectToServer()
can gracefully handle an error inSetServerPassword()
, this seems like it should be a safe fix since we can just store the password in-memory.