Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Italian translation #433

Merged

Conversation

alessandrococco
Copy link
Contributor

@alessandrococco alessandrococco commented Jul 26, 2024

Updates #65

This PR adds Italian translation.


Could someone do a quick review before merging?

Copy link
Owner

@dweymouth dweymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me other than a quick suggestion. And there are some English strings remaining, were you planning on translating those as well? (It's fine if not, just wondering when I should merge). But I set my Mac to Italian and confirmed that the translation loads and looks fine.

res/translations/it.json Outdated Show resolved Hide resolved
@alessandrococco alessandrococco force-pushed the 65-translations-alessandrococco-it branch 2 times, most recently from ff29fb2 to 480216e Compare July 26, 2024 14:58
@alessandrococco
Copy link
Contributor Author

And there are some English strings remaining, were you planning on translating those as well?

Some strings remain the same in both languages (e.g. "album", "playlist", "volume", etc...), some I don't know a good translation (mainly the strings about ReplayGain). There are also some string I would not translate (the strings used in the DisplayReleaseType method).

I pushed some "fix", now you could merge :-)

@alessandrococco alessandrococco marked this pull request as ready for review July 26, 2024 15:02
@alessandrococco alessandrococco force-pushed the 65-translations-alessandrococco-it branch from 480216e to 31abd2e Compare July 26, 2024 15:02
@dweymouth dweymouth merged commit 39d62de into dweymouth:main Jul 26, 2024
@dweymouth
Copy link
Owner

Grazie infinite!

@alessandrococco alessandrococco deleted the 65-translations-alessandrococco-it branch July 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants