refactor: remove ValidateBasic in cli

[lukema95]

Changelist

The ValidateBasic function has been called in the GenerateOrBroadcastTxWithFactory function, so we no longer need to add the ValidateBasic function when writing Cli. Related PRs can be viewed at: cosmos/cosmos-sdk#9236 (comment)

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Walkthrough

The recent modifications across several CLI components of a protocol involve the removal of message validation checks prior to the generation and broadcasting of transactions. This alteration streamlines the transaction process by excluding the preliminary validation step, potentially impacting the control flow and error handling mechanisms within the transaction operations.

Changes

Files	Change Summary
.../clob/client/cli/tx_cancel_order.go, .../tx_place_order.go	Removed message validation before transaction generation/broadcasting.
.../sending/client/cli/tx_create_transfer.go, .../tx_deposit_to_subaccount.go, .../tx_withdraw_from_subaccount.go	Removed message validation before transaction generation/broadcasting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between cc235f0 and 5083144.

Files selected for processing (5)

• protocol/x/clob/client/cli/tx_cancel_order.go (1 hunks)
• protocol/x/clob/client/cli/tx_place_order.go (1 hunks)
• protocol/x/sending/client/cli/tx_create_transfer.go (1 hunks)
• protocol/x/sending/client/cli/tx_deposit_to_subaccount.go (1 hunks)
• protocol/x/sending/client/cli/tx_withdraw_from_subaccount.go (1 hunks)

Files skipped from review due to trivial changes (1)

• protocol/x/sending/client/cli/tx_withdraw_from_subaccount.go

Additional comments: 4

protocol/x/clob/client/cli/tx_cancel_order.go (1)

• 49-52: Confirm that the GenerateOrBroadcastTxCLI function internally calls ValidateBasic for the MsgCancelOrderShortTerm message type to ensure message validation is still performed.

protocol/x/sending/client/cli/tx_create_transfer.go (1)

• 62-65: Confirm that the GenerateOrBroadcastTxCLI function internally calls ValidateBasic for the MsgCreateTransfer message type to ensure message validation is still performed.

protocol/x/clob/client/cli/tx_place_order.go (1)

• 74-78: Confirm that the GenerateOrBroadcastTxCLI function internally calls ValidateBasic for the MsgPlaceOrder message type to ensure message validation is still performed.

protocol/x/sending/client/cli/tx_deposit_to_subaccount.go (1)

• 57-60: Confirm that the GenerateOrBroadcastTxCLI function internally calls ValidateBasic for the MsgDepositToSubaccount message type to ensure message validation is still performed.