Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vault tooltip #827

Merged
merged 3 commits into from
Nov 15, 2024
Merged

fix: vault tooltip #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c175d9
vault-tooltip
tyleroooo Nov 15, 2024
f3b46da
better
tyleroooo Nov 15, 2024
97ffdbf
fix
tyleroooo Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/localization/en/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1713,6 +1713,8 @@
"YOUR_ALL_TIME_PNL": "Your All-time P&L",
"VAULT_THIRTY_DAY_APR": "30d APR",
"APR": "{PERCENT} APR",
"EST_APR_PLAIN": "Est. APR",
"APR_PLAIN": "APR",
"VAULT_THIRTY_DAY_PNL": "30d P&L",
"YOUR_VAULT_BALANCE": "Your Vault Balance",
"VIEW_VAULT": "View Vault",
Expand Down
3 changes: 3 additions & 0 deletions config/localization/en/tooltips.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,9 @@
},
"YOUR_ALL_TIME_PNL": {
"BODY": "The total PnL over time. This includes historical PnL of your vault deposits."
},
"VAULT_APR": {
"BODY": "Vault APR is the annualized return of the vault based on the P&L of the past 30 days."
}
}
}
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dydxprotocol/v4-localization",
"version": "1.1.245",
"version": "1.1.246",
"description": "v4 localization",
"main": "index.ts",
"scripts": {
Expand Down
2 changes: 2 additions & 0 deletions scripts/generated/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1920,6 +1920,7 @@ export const APP_STRING_KEYS = {
AMOUNT_TO_DEPOSIT: 'APP.VAULTS.AMOUNT_TO_DEPOSIT',
AMOUNT_TO_WITHDRAW: 'APP.VAULTS.AMOUNT_TO_WITHDRAW',
APR: 'APP.VAULTS.APR',
APR_PLAIN: 'APP.VAULTS.APR_PLAIN',
AVAILABLE_TO_WITHDRAW: 'APP.VAULTS.AVAILABLE_TO_WITHDRAW',
CONFIRM_DEPOSIT_CTA: 'APP.VAULTS.CONFIRM_DEPOSIT_CTA',
CONFIRM_WITHDRAW_CTA: 'APP.VAULTS.CONFIRM_WITHDRAW_CTA',
Expand All @@ -1930,6 +1931,7 @@ export const APP_STRING_KEYS = {
ENTER_AMOUNT_TO_WITHDRAW: 'APP.VAULTS.ENTER_AMOUNT_TO_WITHDRAW',
ESTIMATED_AMOUNT_RECEIVED: 'APP.VAULTS.ESTIMATED_AMOUNT_RECEIVED',
ESTIMATED_SLIPPAGE: 'APP.VAULTS.ESTIMATED_SLIPPAGE',
EST_APR_PLAIN: 'APP.VAULTS.EST_APR_PLAIN',
EST_SLIPPAGE: 'APP.VAULTS.EST_SLIPPAGE',
HOLDINGS: 'APP.VAULTS.HOLDINGS',
LEARN_MORE_ABOUT_MEGAVAULT: 'APP.VAULTS.LEARN_MORE_ABOUT_MEGAVAULT',
Expand Down
1 change: 1 addition & 0 deletions scripts/generated/tooltips.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ export const TOOLTIP_STRING_KEYS = {
AVAILABLE_TO_WITHDRAW_BODY: 'TOOLTIPS.VAULT.AVAILABLE_TO_WITHDRAW.BODY',
ESTIMATED_AMOUNT_RECEIVED_BODY: 'TOOLTIPS.VAULT.ESTIMATED_AMOUNT_RECEIVED.BODY',
ESTIMATED_SLIPPAGE_BODY: 'TOOLTIPS.VAULT.ESTIMATED_SLIPPAGE.BODY',
VAULT_APR_BODY: 'TOOLTIPS.VAULT.VAULT_APR.BODY',
YOUR_ALL_TIME_PNL_BODY: 'TOOLTIPS.VAULT.YOUR_ALL_TIME_PNL.BODY',
YOUR_VAULT_BALANCE_BODY: 'TOOLTIPS.VAULT.YOUR_VAULT_BALANCE.BODY',

Expand Down
Loading