Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Parcel for std::ffi::CString #22

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Implement Parcel for std::ffi::CString #22

merged 2 commits into from
Jul 15, 2020

Conversation

anarelion
Copy link
Contributor

@anarelion anarelion commented Jul 2, 2020 •
edited
Loading

This allows protocols to implement null terminated strings

Resolves #21

@anarelion anarelion mentioned this pull request Jul 2, 2020
Closed
dylanmckay
dylanmckay requested changes Jul 3, 2020
View reviewed changes
Copy link
Owner

@dylanmckay dylanmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is looking good, nice.

I've left a few suggestions, once they are fixed I will be happy to merge this and publish a new version of the crate.

Thanks for the patch @anarelion

protocol/src/types/cstring.rs Outdated Show resolved Hide resolved
protocol/src/types/cstring.rs Show resolved Hide resolved
protocol/src/types/cstring.rs Outdated Show resolved Hide resolved
protocol/src/types/cstring.rs Outdated Show resolved Hide resolved
protocol/src/errors.rs Outdated Show resolved Hide resolved
protocol/src/types/cstring.rs Outdated Show resolved Hide resolved
@anarelion anarelion requested a review from dylanmckay July 6, 2020 08:01
@anarelion
Copy link
Contributor Author

I am not sure if I should be resolving conversations as I did or not. I am not used to github. I find git very confusing.

@dylanmckay
Copy link
Owner

I don't mind - it'd be remiss of me to not look over them anyway so it doesn't make much difference to me - I suppose leaving them unresolved for the reviewer could make it easier if this PR went through many iterations. At the end of the day, Moses never came down and instructed either or the other.

The patch looks good, appreciate it @anarelion - I will merge it now and release a new version of the crate.

@dylanmckay dylanmckay merged commit 0cdb2db into dylanmckay:master Jul 15, 2020
@dylanmckay
Copy link
Owner

Released 3.1.7 which includes this patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanmckay dylanmckay dylanmckay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null terminated strings
2 participants
@anarelion @dylanmckay