-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several macro attributes #26
base: master
Are you sure you want to change the base?
Conversation
Make length prefix usable more that once
I also implemented the possibility to use a length prefix multiple time like this : #[derive(Protocol, Debug, PartialEq, Eq)]
pub struct WithElementsLengthUsedTwice {
pub count: u32,
pub foo: bool,
#[protocol(length_prefix(elements(count)))]
pub data_1: Vec<u32>,
#[protocol(length_prefix(elements(count)))]
pub data_2: Vec<u32>,
} @dylanmckay I am waiting for your feedback before updating the documentation. |
I started to work on a "skip_if" attribute, for now the derive implementation is quite naive (and only It looks like this : #[derive(Protocol, Debug, PartialEq, Eq)]
struct SkipIfField {
pub condition: bool,
#[protocol(skip_if("condition"))]
pub message: Option<u8>,
}
#[derive(Protocol, Debug, PartialEq, Eq)]
struct SkipIfBinaryExp {
pub condition: u8,
#[protocol(skip_if("condition == 7"))]
pub message: Option<u8>,
} This only works on struct named field, I don't know if we want this for other kind of field. |
This is a feature I'd also like! @dylanmckay is there a chance this will be merged? I don't mind helping to finish up the docs? |
I implemented what I asked for in #25
Let me know if you think that might be useful and if I need to change anything.