-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIMD]: Java Vector API usage #706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mfirry for bringing this forward!
One single blocker and a just nitpicks we chatted about.
long resultHigh = 0L; | ||
var v1 = | ||
LongVector.fromArray( | ||
LongVector.SPECIES_128, new long[] {low, high}, stack.size() - 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The offset here should be 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job @mfirry !
Addresses #695
Thi is the first batch of functionalities leveraging on Java Vector API.