Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIMD]: Java Vector API usage #706

Merged
merged 17 commits into from
Dec 12, 2024
Merged

[SIMD]: Java Vector API usage #706

merged 17 commits into from
Dec 12, 2024

Conversation

mfirry
Copy link
Contributor

@mfirry mfirry commented Dec 12, 2024

Addresses #695

Thi is the first batch of functionalities leveraging on Java Vector API.

Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfirry for bringing this forward!
One single blocker and a just nitpicks we chatted about.

long resultHigh = 0L;
var v1 =
LongVector.fromArray(
LongVector.SPECIES_128, new long[] {low, high}, stack.size() - 2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The offset here should be 0

Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @mfirry !

@andreaTP andreaTP merged commit 73f631c into dylibso:main Dec 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants