-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use clap for cli argument parsing #18
use clap for cli argument parsing #18
Conversation
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Waiting on #16, as it also touches the same lines as this PR. I also need to add the |
Previously this was outputting `main.wasm` Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Thanks, this looks cleaner and more maintainable than the hand parsing. After you rebase and add the chmod note, could you please post size comparisons? I doubt this adds much, but I do want to be careful about hermit's size moving forward. |
I added that in a14c49f, however it is only visible under Main reason for the difference between the two is that |
* feat: apply clippy suggestions and replace helper function with builtin one. * feat: add a 'release' profile to hermit-cli to be used only when specified.
I am going to recreate this PR tomorrow. Messed up bad |
Before
hermit.com -h
orhermit.com --help
After
hermit.com -h
hermit.com --help
closes: #17