cleanup: use simplify sortedProperties to potentially more JS allocat…

…or friendly way
dylibso · Nov 19, 2024 · e89d637 · e89d637
1 parent b46f6d8
commit e89d637
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -310,16 +310,12 @@ function numRequiredProperties(object: Schema) {
 
 function sortedProperties(object: Schema) {
   const properties: Property[] = []
-  let curRequiredProperties = 0
+  const requiredProperties: Property[] = []
   for (const prop of object.properties) {
-    if (!isPropertyRequired(prop)) {
-      properties.push(prop)
-      continue;
-    }
-    properties.splice(curRequiredProperties, 0, prop)
-    curRequiredProperties++
+    const target = (isPropertyRequired(prop) ? requiredProperties : properties)
+    target.push(prop)
   }
-  return properties
+  return [...requiredProperties, ...properties]
 }
 
 function isTypeUntypedObject(type: XtpNormalizedType) {