fix: add default value for optional fields #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Currently when constructing a type with nullable fields the user is required to explicitly pass
None
if no argument is needed.This sets
nullable
fields toNone
by default - to do this we need to list all non-nullable fields first, then the nullable ones because Python requires arguments with default values to be listed last. This means the order of arguments for type constructors might be in a different order from the schema and other PDKs, but I'm not sure there is another way around this.