refactor: add errorlint and make fmt.Errorf use %w to wrap error inst…

…ead of %v (#878)

.golangci.yml

@@ -48,6 +48,7 @@ linters:
     - typecheck
     - unconvert
     - unused
+    - errorlint
 
 issues:
   exclude-use-default: false

cmd/dymd/cmd/inspect.go

@@ -69,7 +69,7 @@ func InspectCmd(appExporter types.AppExporter, appCreator types.AppCreator, defa
 			height, _ := cmd.Flags().GetInt64(FlagHeight)
 			exported, err := appExporter(serverCtx.Logger, db, traceWriter, height, false, []string{}, serverCtx.Viper)
 			if err != nil {
-				return fmt.Errorf("error exporting state: %v", err)
+				return fmt.Errorf("exporting state: %w", err)
 			}
 
 			appState := exported.AppState
@@ -116,7 +116,7 @@ func InspectCmd(appExporter types.AppExporter, appCreator types.AppCreator, defa
 			dataDir := filepath.Join(config.RootDir, "data")
 			directories, err := os.ReadDir(dataDir)
 			if err != nil {
-				return fmt.Errorf("Error reading directory: %v", err)
+				return fmt.Errorf("reading directory: %w", err)
 			}
 
 			for _, dir := range directories {

cmd/dymd/main.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"errors"
 	"os"
 
 	"github.com/cosmos/cosmos-sdk/server"
@@ -13,10 +14,10 @@ import (
 func main() {
 	rootCmd, _ := cmd.NewRootCmd()
 	if err := svrcmd.Execute(rootCmd, "", app.DefaultNodeHome); err != nil {
-		switch e := err.(type) {
-		case server.ErrorCode:
+		var e server.ErrorCode
+		switch {
+		case errors.As(err, &e):
 			os.Exit(e.Code)
-
 		default:
 			os.Exit(1)
 		}

x/delayedack/eibc.go

@@ -60,12 +60,12 @@ func (im IBCMiddleware) eIBCDemandOrderHandler(ctx sdk.Context, rollappPacket co
 
 	eibcDemandOrder, err := im.createDemandOrderFromIBCPacket(data, &rollappPacket, *packetMetaData.EIBC)
 	if err != nil {
-		return fmt.Errorf("create eibc demand order: %s", err)
+		return fmt.Errorf("create eibc demand order: %w", err)
 	}
 
 	err = im.keeper.SetDemandOrder(ctx, eibcDemandOrder)
 	if err != nil {
-		return fmt.Errorf("set eibc demand order: %s", err)
+		return fmt.Errorf("set eibc demand order: %w", err)
 	}
 	return nil
 }
@@ -130,7 +130,7 @@ func (im IBCMiddleware) createDemandOrderFromIBCPacket(fungibleTokenPacketData t
 
 	order := eibctypes.NewDemandOrder(*rollappPacket, demandOrderPrice, fee, demandOrderDenom, demandOrderRecipient)
 	if err := order.Validate(); err != nil {
-		return nil, fmt.Errorf("validate eibc data: %s", err)
+		return nil, fmt.Errorf("validate eibc data: %w", err)
 	}
 	return order, nil
 }